Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEP Dependencies for CMS 6 #70

Merged
merged 1 commit into from
Feb 20, 2024
Merged

DEP Dependencies for CMS 6 #70

merged 1 commit into from
Feb 20, 2024

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz mentioned this pull request Feb 19, 2024
Closed
GuySartorelli
GuySartorelli previously approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Failures are expected at this stage so ignoring CI.

@GuySartorelli
Copy link
Member

Lets just ditch this one actually. There's NO WAY we're supporting this for CMS 6.

@GuySartorelli GuySartorelli dismissed their stale review February 19, 2024 21:52

approved too soon

@emteknetnz
Copy link
Member Author

We'll create a CMS 6 branch for now and look at support at a later date

GuySartorelli
GuySartorelli approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is absolutely insane that we're pretending we're gonna make this CMS 6 compatible....

@GuySartorelli GuySartorelli merged commit 77c6902 into silverstripe:4 Feb 20, 2024
5 of 10 checks passed
@GuySartorelli GuySartorelli deleted the pulls/4/module-standardiser-1708320452 branch February 20, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli