MNT Behat test for gridfield object on page #259
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
requested changes
Jan 7, 2024
sabina-talipova
force-pushed
the
pulls/5/support-click-gridfield
branch
from
1013961
to
8d2e749
Compare
sabina-talipova
force-pushed
the
pulls/5/support-click-gridfield
branch
from
8d2e749
to
15e24f9
Compare
sabina-talipova
commented
Jan 8, 2024
| @@ -510,6 +510,9 @@ public function iClickInTheElement($clickType, $text, $selector) | |||
| $parentElement = $page->find('css', $selector); | |||
| Assert::assertNotNull($parentElement, sprintf('"%s" element not found', $selector)); | |||
| $element = $parentElement->find('xpath', sprintf('//*[count(*)=0 and contains(.,"%s")]', $text)); | |||
| if (is_null($element)) { | |||
| $element = $parentElement->find('xpath', sprintf('//*[text()[contains(.,"%s")]]', $text)); | |||
| } | |||
There was a problem hiding this comment.
I added this as an additional check in case these changes might break existing tests. This expression also works with other elements in another behat tests (e.g. silverstripe-admin), but I'm afraid that in some tests the selected elements will not be clickable.
See: https://stackoverflow.com/questions/3655549/xpath-containstext-some-string-doesnt-work-when-used-with-node-with-more/71255563#71255563
|
Closing - we can reference this PR if we decide to go forward with this work in the future, pending the spike. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New test function to find all elements by provided selector.
Parent issue