Fix build on windows #1138
Merged
Fix build on windows #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated to use fileURLToPath which looks like a better fix. |
|
Ok indeed, your previous suggestion actually changed behavior but this looks good. Not a huge fan of starting to rely on node.js APIs, but for builds I think it's ok. Let me quickly check if this doesn't break anything on other platforms. |
|
Looks good. Thanks! |
|
Still new to Deno, but I think this could have been done with fromFileUrl to avoid dependency on the Node API. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the build on windows, where
new URL("deno.json", import.meta.url).pathnamestarts with/C:/which isn't a valid path.First time with deno, so not sure this is idomatic.