Conversation
Contributor
|
The indentation here was intentional, to make it interpreted as a code block in markdown. |
emeirola
approved these changes
Oct 15, 2025
Gastron
added a commit
that referenced
this pull request
Oct 20, 2025
* Fix the data format documentation * Try to avoid segmentation fault on GHA * Try to avoid segmentation fault on GHA - trigger fix * Use gemma2 instead of mistral * gemma2 loss margins lower * gemma2 loss margins even lower * Add the indentation back
Gastron
added a commit
that referenced
this pull request
Oct 21, 2025
* Make SFT and DPO config documentation * Fix the data format documentation (#13) * Fix the data format documentation * Try to avoid segmentation fault on GHA * Try to avoid segmentation fault on GHA - trigger fix * Use gemma2 instead of mistral * gemma2 loss margins lower * gemma2 loss margins even lower * Add the indentation back * Generate with DPO-specific text, handle versions in links * Fix typo --------- Co-authored-by: Emil Eirola <emil.eirola@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Besides the data format documentation, now this also fixes the github action checks that lead to a segmentation fault. Because of lower prioritization and inability to reproduce the segmentation fault elsewhere, I've simply switched out the tiny-random-MistralForCausalLM that lead to the issue.