Merged
Conversation
6d4537c to
d46b38c
Compare
Add support for specifying target revision when bootstrapping cluster-forge: - New -r/--target-revision flag for bootstrap script - Git ancestry validation ensures only v1.8.0-rc1+ compatible revisions - Support for branches, tags, and commit hashes - Handles both local and remote branches (origin/branch-name) - Enhanced argument parsing with backwards compatibility - Simplified validation removes pre-v1.8.0 support complexity The flag allows developers to bootstrap from feature branches while ensuring compatibility with the v1.8.0+ architecture requirements.
7b3f80b to
ded11b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add --target-revision flag for bootstrap script with git ancestry validation
Summary
This PR introduces a new
--target-revision(-r) flag to the cluster-forge bootstrap script, allowing developers to bootstrap clusters from specific git revisions (branches, tags, or commits) while maintaining compatibility guarantees through git ancestry validation.Problem Statement
Previously, the bootstrap script was hardcoded to use specific versions (v1.8.0-rc2), making it difficult for developers to:
Additionally, there was a timing issue where ArgoCD applications would initially sync to the hardcoded revision before eventually switching to the intended target revision, causing unnecessary syncs.
Solution
🚀 Feature Implementation (commit 7dc274a)
-r/--target-revisionwith support for branches, tags, and commitsorigin/branch-namepatterns🔧 Timing Fix (commit b5a0898)
🧹 Template Cleanup (commit ded11b6)
clusterSizelogicglobal.clusterSizenow always defined by bootstrap scriptUsage Examples
./scripts/bootstrap.sh -r=EAI-1436_validation cluster.example.com
./scripts/bootstrap.sh --target-revision=v1.8.2 prod.example.com
./scripts/bootstrap.sh cluster.example.com
./scripts/bootstrap.sh -r=feature-branch -s=small dev.example.com
Validation & Safety
Impact
Benefits
Files Modified
Testing
The feature has been tested with:
Breaking Changes: None. All existing bootstrap script usage continues to work as before.