Skip to content

Better visibility into malformed ClearML responses#880

Merged
Enkidu93 merged 1 commit intomainfrom
malformed_clearml_response_details
Feb 24, 2026
Merged

Better visibility into malformed ClearML responses#880
Enkidu93 merged 1 commit intomainfrom
malformed_clearml_response_details

Conversation

@Enkidu93
Copy link
Collaborator

@Enkidu93 Enkidu93 commented Feb 23, 2026

If the response is not JSON, we include it properly in the exception message, but if it is JSON without the expected required properties, all we say is "Malformed response...". I don't see in the ClearML documentation how this would happen exactly, but I saw one of these errors on QA, so it can happen!


This change is Reviewable

@Enkidu93 Enkidu93 requested a review from ddaspit February 23, 2026 23:01
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.93%. Comparing base (40290bc) to head (c6119b4).

Files with missing lines Patch % Lines
...c/Serval.Machine.Shared/Services/ClearMLService.cs 0.00% 21 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #880      +/-   ##
==========================================
- Coverage   66.96%   66.93%   -0.04%     
==========================================
  Files         384      384              
  Lines       20889    20900      +11     
  Branches     2700     2709       +9     
==========================================
  Hits        13989    13989              
- Misses       5936     5947      +11     
  Partials      964      964              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ddaspit reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Enkidu93).

@Enkidu93 Enkidu93 merged commit 04d4719 into main Feb 24, 2026
2 checks passed
@Enkidu93 Enkidu93 deleted the malformed_clearml_response_details branch February 24, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants