-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
+semver:major [SIL.WritingSystems] Add UI font role #1389
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Palaso Tests 4 files 4 suites 16m 20s ⏱️ Results for commit ff71933. ♻️ This comment has been updated with latest results. |
@ermshiperete For the roundtrip tests to work with XML files that have a font without any type specified, I thought it would make sense to change the code to default to |
I don't know the answer to that question and I don't know where that class is used. You might want to ask on Slack. |
No responses in #commonlibraries; should I ask again in LT Software's #public or LT's #general? |
Everyone who cares should watch #commonlibraries; otherwise it's documented as breaking change in the changelog, so I think we're good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 6 files at r2, 1 of 1 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
Resolves #1212 (implementing #1212 (comment))
This change is