Skip to content

remove browse view #1825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

remove browse view #1825

wants to merge 7 commits into from
+27 −16,697

Conversation

hahn-kev
Copy link
Collaborator

the poor browse view has been broken and not worked for a while now. It's time to remove it, every time we add something new to the MiniLcm api we have to touch the browse view, even though it's not working, so it's not worth keeping any of that around.

I've decided to leave in the API, so we could still use that in the future if we wanted.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jul 15, 2025 •
edited
Loading

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

This change removes the "viewer" feature from the frontend, including its Svelte routes, supporting TypeScript API class, Playwright tests, and related configuration and build logic. Associated build and workflow scripts are simplified or updated to remove references to the viewer. Docker and package configuration files are also revised to exclude the viewer from build contexts and dependencies.

Changes

Files/Groups Change Summary
frontend/src/routes/(authenticated)/project/[project_code]/viewer/* Deleted all viewer-related Svelte files, including layout, page, page logic, and API class.
frontend/tests/pages/viewerPage.ts, frontend/tests/viewerPage.test.ts Removed Playwright page object and all end-to-end tests for the viewer feature.
frontend/viewer/Taskfile.yml, frontend/platform.bible-extension/Taskfile.yml, frontend/Taskfile.yml Renamed and updated build/dev tasks to remove "-app" suffix, update dependencies, and commands.
frontend/viewer/package.json Removed "main" and "exports" fields; consolidated and simplified scripts for dev/build.
frontend/viewer/vite.config.ts Removed conditional web component build logic; simplified configuration.
frontend/viewer/playwright.config.ts Updated web server command from dev-app to dev.
.github/workflows/fw-lite.yaml, frontend/Dockerfile, frontend/dev.Dockerfile, frontend/.dockerignore Updated build steps, Docker ignore, and workflow to remove viewer-specific logic and context.
frontend/package.json Removed "viewer" workspace dependency.
frontend/src/routes/(authenticated)/project/[project_code]/+page.svelte, +page.ts Removed viewer button and related project field from project page and its data query.

Suggested reviewers

  • hahn-kev

Poem

🐇
The viewer has hopped away,
No more buttons to display.
Tasks and scripts are now concise,
Docker builds trimmed down nice.
With tests and routes now out of sight,
The frontend feels a little more light!
— A tidy rabbit’s delight.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added 💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related 📦 Lexbox issues related to any server side code, fw-headless included labels Jul 15, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 15, 2025 •
edited
Loading

UI unit Tests

  1 files  ±0   38 suites  ±0   19s ⏱️ -1s
 80 tests ±0   80 ✅ ±0  0 💤 ±0  0 ❌ ±0 
111 runs  ±0  111 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit c8b1765. ± Comparison against base commit 0977a0a.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 15, 2025 •
edited
Loading

C# Unit Tests

126 tests  ±0   126 ✅ ±0   12s ⏱️ ±0s
 20 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit c8b1765. ± Comparison against base commit 0977a0a.

♻️ This comment has been updated with latest results.

@argos-ci Argos CI
Copy link

argos-ci bot commented Jul 15, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Jul 16, 2025, 3:17 AM

imnasnainaec
imnasnainaec reviewed Jul 15, 2025
View reviewed changes
imnasnainaec
imnasnainaec reviewed Jul 15, 2025
View reviewed changes
imnasnainaec
imnasnainaec reviewed Jul 15, 2025
View reviewed changes
imnasnainaec
imnasnainaec reviewed Jul 15, 2025
View reviewed changes
imnasnainaec
imnasnainaec reviewed Jul 15, 2025
View reviewed changes
Copy link
Collaborator

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dist-web-component could be dropped from frontend/viewer/.gitignore

hahn-kev added 2 commits July 16, 2025 10:13
@hahn-kev
rename some taskfile stuff
3e78ad6
@hahn-kev
Merge branch 'develop' into remove-browse-view
c8b1765 
# Conflicts:
#	frontend/src/routes/(authenticated)/project/[project_code]/viewer/lfClassicLexboxApi.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imnasnainaec imnasnainaec imnasnainaec left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related 📦 Lexbox issues related to any server side code, fw-headless included
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hahn-kev @imnasnainaec