feat: Make heading links work (#20) #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-polk
force-pushed
the
HeadingLinks
branch
2 times, most recently
from
1b7ae59 to
1e450ca
Compare
gmartin7
approved these changes
Dec 1, 2022
andrew-polk
force-pushed
the
HeadingLinks
branch
from
1e450ca to
088e6a6
Compare
gmartin7
approved these changes
Dec 1, 2022
| let convertedLink = layoutStrategy.getLinkPathForPage(page); | ||
|
|
||
| // Include the fragment (# and after) if it exists | ||
| const { fragmentId } = parseLinkId(url); |
There was a problem hiding this comment.
I guess you don't need baseLinkId here too, just to keep the destructuring happy?
andrew-polk
commented
Dec 1, 2022
There was a problem hiding this comment.
Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @gmartin7)
src/links.ts line 18 at r1 (raw file):
Previously, gmartin7 (Gordon Martin) wrote…
I guess you don't need
baseLinkIdhere too, just to keep the destructuring happy?
Nope.
gmartin7
reviewed
Dec 1, 2022
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
|
🎉 This PR is included in version 0.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is