Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract TreeSearch from TreeViewHeader #1352

Merged
merged 15 commits into from
Sep 14, 2021
Merged

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Sep 1, 2021

Resolves #1340
Resolves #684 (by removing the bounce animation, which opens #1368)


This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Sep 1, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2021

Codecov Report

Merging #1352 (e01d8d4) into master (fc1d10e) will increase coverage by 0.20%.
The diff coverage is 81.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1352      +/-   ##
==========================================
+ Coverage   51.13%   51.34%   +0.20%     
==========================================
  Files         255      256       +1     
  Lines        7844     7853       +9     
  Branches      560      558       -2     
==========================================
+ Hits         4011     4032      +21     
+ Misses       3385     3375      -10     
+ Partials      448      446       -2     
Flag Coverage Δ
backend 77.01% <ø> (+0.06%) ⬆️
frontend 32.42% <81.25%> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/components/TreeView/TreeViewComponent.tsx 56.66% <ø> (ø)
src/components/TreeView/TreeViewHeader.tsx 75.00% <50.00%> (+1.76%) ⬆️
src/components/TreeView/TreeSearch.tsx 74.46% <74.46%> (ø)
src/components/TreeView/TreeDepiction.tsx 87.71% <89.13%> (+21.05%) ⬆️
src/components/TreeView/DomainTile.tsx 90.00% <100.00%> (ø)
Backend/Helper/DuplicateFinder.cs 88.76% <0.00%> (+1.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc1d10e...e01d8d4. Read the comment docs.

@imnasnainaec imnasnainaec marked this pull request as ready for review September 7, 2021 17:22
Copy link
Contributor

@JacobHaimes JacobHaimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 17 of 17 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @WeJamUS)

Copy link
Contributor

@WeJamUS WeJamUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 11 of 17 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@johnthagen johnthagen changed the title Extract TreeSearch from TreeViewHeader. Extract TreeSearch from TreeViewHeader Sep 10, 2021
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 17 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 5fe0ec9 into master Sep 14, 2021
@imnasnainaec imnasnainaec deleted the treeview-extract-search branch September 14, 2021 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants