#62 Improved FileUpdate replacement verification and error handling

[tombogle]

---

This change is 

[github-actions]

Test Results

    2 files   -     2    21 suites   - 15   11s ⏱️ -18s
191 tests +    9  190 ✔️ +    8  1 💤 +1  0 ❌ ±0 
191 runs   - 173  190 ✔️  - 172  1 💤  - 1  0 ❌ ±0 

Results for commit 98793b6. ± Comparison against base commit 5b34099.

♻️ This comment has been updated with latest results.

[andrew-polk]

Looks like you need a changelog entry.

Reviewed 4 of 8 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ermshiperete and @tombogle)

---

SIL.BuildTasks/FileUpdate.cs line 51 at r2 (raw file):

		}

		internal string GetModifiedContents(string content, out bool success)

Do you think this is better?

internal bool TryGetModifiedContents(string content, out string modifiedContents)

If not, looks ok as is...

[tombogle]

SIL.BuildTasks/FileUpdate.cs line 51 at r2 (raw file):

Previously, andrew-polk wrote…

Do you think this is better?

internal bool TryGetModifiedContents(string content, out string modifiedContents)

If not, looks ok as is...

I reworked this in a much simpler way. (To me, the problem with Try... is that it implies that whether it succeeds or not, the result is equally acceptable, but in this case, failure really is an exception and will normally be treated as a build failure.

[andrew-polk]

Reviewed 4 of 4 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ermshiperete)

[andrew-polk]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ermshiperete)