Skip to content

Fix LT-22173: Running 'Delete Entries' utility twice crashes #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jtmaxwell3 merged 1 commit into from
Feb 26, 2026
Merged

Fix LT-22173: Running 'Delete Entries' utility twice crashes #714

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Src/LexText/Lexicon/DeleteEntriesSensesWithoutInterlinearization.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright (c) 2015 SIL International
// Copyright (c) 2015 SIL International
// This software is licensed under the LGPL, version 2.1 or later
// (http://www.gnu.org/licenses/lgpl-2.1.html)

Expand Down Expand Up @@ -110,17 +110,17 @@ void DeleteUnusedEntriesAndSenses(LcmCache cache, ProgressBar progressBar)
}
}

progressBar.Value = 1;
progressBar.Maximum = entriesToDel.Count;
progressBar.Value = Math.Min(1, progressBar.Maximum);
foreach (var entry in entriesToDel)
{
progressBar.PerformStep();
cache.DomainDataByFlid.DeleteObj(entry.Hvo);
}

var senses = cache.ServiceLocator.GetInstance<ILexSenseRepository>().AllInstances().ToArray();
progressBar.Value = 1;
progressBar.Maximum = senses.Length;
progressBar.Value = Math.Min(1, progressBar.Maximum);
foreach (var sense in senses)
{
progressBar.PerformStep();
Expand Down
Loading