Conversation
Cherry-pick from the PubSub branch to the main branch using the following command: git cherry-pick --no-commit b82f926 After the cherry-pick additional edits were made to resolve conflicts and standardize on the use of: using static SIL.FieldWorks.Common.FwUtils.FwUtils;
papeh
requested changes
Jan 27, 2026
Src/xWorks/xWorksTests/DictionaryConfigurationMigrators/StubContentControlProvider.cs
Show resolved
Hide resolved
mark-sil
commented
Jan 27, 2026
Contributor
Author
mark-sil
left a comment
mark-sil
left a comment
There was a problem hiding this comment.
@mark-sil made 1 comment.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @papeh).
Src/xWorks/xWorksTests/DictionaryConfigurationMigrators/StubContentControlProvider.cs
Show resolved
Hide resolved
papeh
approved these changes
Jan 27, 2026
papeh
reviewed
Jan 27, 2026
| public void Dispose(bool disposeCalled) | ||
| { | ||
| System.Diagnostics.Debug.WriteLineIf(!disposeCalled, "****** Missing Dispose() call for " + GetType().Name + ". ****** "); | ||
| Subscriber.Unsubscribe(EventConstants.GetContentControlParameters, GetContentControlParameters); |
Contributor
There was a problem hiding this comment.
On second thought, unsubscribing during garbage collection may not be a good idea.
| Subscriber.Unsubscribe(EventConstants.ReloadAreaTools, ReloadAreaTools); | ||
| Subscriber.Unsubscribe(EventConstants.GetContentControlParameters, GetContentControlParameters); | ||
|
|
||
| // Dispose managed resources here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick from the PubSub branch to the main branch using the following command:
git cherry-pick --no-commit b82f926
After the cherry-pick additional edits were made to resolve conflicts and standardize on the use of:
using static SIL.FieldWorks.Common.FwUtils.FwUtils;
This change is