Skip to content

Fix LT-22147: "Clear current word's parser analyses" fails for UC words #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jtmaxwell3 merged 1 commit into from
Jan 20, 2026
Merged

Fix LT-22147: "Clear current word's parser analyses" fails for UC words #626

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 27 additions & 9 deletions Src/LexText/ParserUI/ParserListener.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,21 +431,39 @@ public bool OnClearSelectedWordParserAnalyses(object dummyObj)
UndoableUnitOfWorkHelper.Do(ParserUIStrings.ksUndoClearParserAnalyses,
ParserUIStrings.ksRedoClearParserAnalyses, m_cache.ActionHandlerAccessor, () =>
{
foreach (IWfiAnalysis analysis in wf.AnalysesOC.ToArray())
ClearWordformAnalyses(wf);
// Clear lower-case version of wf.
var vernWs = wf.Form.BestVernacularAlternative.get_WritingSystemAt(0);
var cf = new CaseFunctions(m_cache.ServiceLocator.WritingSystemManager.Get(vernWs));
string word = wf.Form.BestVernacularAlternative.Text;
string lcWord = cf.ToLower(word);
if (lcWord != word)
{
ICmAgentEvaluation[] parserEvals = analysis.EvaluationsRC.Where(evaluation => !evaluation.Human).ToArray();
foreach (ICmAgentEvaluation parserEval in parserEvals)
analysis.EvaluationsRC.Remove(parserEval);

if (analysis.EvaluationsRC.Count == 0)
wf.AnalysesOC.Remove(analysis);

wf.Checksum = 0;
if (m_cache.ServiceLocator.GetInstance<IWfiWordformRepository>().TryGetObject(
TsStringUtils.MakeString(lcWord, vernWs), true, out IWfiWordform lcWf))
{
ClearWordformAnalyses(lcWf);
}
}
});
return true; //we handled this.
}

private void ClearWordformAnalyses(IWfiWordform wf)
{
foreach (IWfiAnalysis analysis in wf.AnalysesOC.ToArray())
{
ICmAgentEvaluation[] parserEvals = analysis.EvaluationsRC.Where(evaluation => !evaluation.Human).ToArray();
foreach (ICmAgentEvaluation parserEval in parserEvals)
analysis.EvaluationsRC.Remove(parserEval);

if (analysis.EvaluationsRC.Count == 0)
wf.AnalysesOC.Remove(analysis);

wf.Checksum = 0;
}
}

#endregion ClearSelectedWordParserAnalyses handlers

public bool OnDisplayParseCurrentWord(object commandObject, ref UIItemDisplayProperties display)
Expand Down
Loading