LT-22312: Make copyright more accessible in Webonary#611
Merged
aror92 merged 3 commits intorelease/9.3from Jan 7, 2026
Merged
Conversation
Create GeneratePictureLicenseContent method in LcmGenerator that returns a string containing picture copyright and license info. In GenerateContentForPicture, use this new method to generate the license content and add license as an argument to AddImage. In "AddImage" in the Xhtml generator, add the license as a title in the image element, so that license will display when mousing over the image. In "AddImage" in the JSON generator, add a "copyrightLicense" property to the image data so it will be searchable in the database. Change-Id: Ice63fbd238e41ec94dc1ebe8178ec727919ec481
Change-Id: Ia5bbd365d1cd7240e8544a916db415716f6b161b
Contributor
Author
|
Two JSON generator tests are failing because the expected results need to be updated to include the copyrightLicense property. I'm updating those now. |
Change-Id: I3c41e011a89b4a6e4fcd81df6cbb73b0a266ad45
jasonleenaylor
approved these changes
Jan 7, 2026
Contributor
jasonleenaylor
left a comment
jasonleenaylor
left a comment
There was a problem hiding this comment.
Very nice work!
@jasonleenaylor partially reviewed 6 files and made 1 comment.
Reviewable status: 5 of 6 files reviewed, all discussions resolved (waiting on @aror92).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create GeneratePictureLicenseContent method in LcmGenerator that returns a string containing picture copyright and license info.
In GenerateContentForPicture, use this new method to generate the license content and add license as an argument to AddImage.
In "AddImage" in the Xhtml generator, add the license as a title in the image element, so that license will display when mousing over the image.
In "AddImage" in the JSON generator, add a "copyrightLicense" property to the image data so it will be searchable in the database.
This change is