Fix LT-22346: Crash occurs using lexicon edit popup#609
Fix LT-22346: Crash occurs using lexicon edit popup#609jtmaxwell3 merged 2 commits intorelease/9.3from
Conversation
mark-sil
left a comment
There was a problem hiding this comment.
@mark-sil made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @jtmaxwell3).
Src/LexText/LexTextControls/InsertEntryDlg.cs line 1352 at r1 (raw file):
if (DialogResult == DialogResult.Retry) { m_mediator.PostMessage("JumpToPopupLexEntry", m_entry.Hvo);
Was the change from SendMessage() to PostMessage() a necessary part of the fix?
The reason I ask is because we are in the process of replacing most of the mediator functionality with Pub/Sub functionality, and SendMessage() calls are an order of magnitude easier to replace than PostMessage() calls.
mark-sil
left a comment
There was a problem hiding this comment.
@mark-sil reviewed 1 file and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @jtmaxwell3).
mark-sil
left a comment
There was a problem hiding this comment.
@mark-sil reviewed 1 file and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jtmaxwell3).
mark-sil
left a comment
There was a problem hiding this comment.
@mark-sil reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved.
mark-sil
left a comment
There was a problem hiding this comment.
@mark-sil reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved.
This fixes https://jira.sil.org/browse/LT-22346. Insert Part Relation wasn't closing because it expected DialogResult.OK, but we were using DialogResult.Retry for "Create and Edit". I also changed SendMessage to PostMessage to give the Insert Part Relation dialog time to close before the popup opened.
This change is