Fix LT-22303: Import flextext adds a paragraph marker#601
Merged
jtmaxwell3 merged 2 commits intorelease/9.3from Jan 9, 2026
Merged
Fix LT-22303: Import flextext adds a paragraph marker#601jtmaxwell3 merged 2 commits intorelease/9.3from
jtmaxwell3 merged 2 commits intorelease/9.3from
Conversation
Collaborator
Author
|
I replaced EndsWithEOS with ParagraphParser.EndsWithEOS, which should do a better job of determining whether a text ends with EOS. |
jasonleenaylor
approved these changes
Jan 9, 2026
Contributor
jasonleenaylor
left a comment
jasonleenaylor
left a comment
There was a problem hiding this comment.
@jasonleenaylor reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jtmaxwell3).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes https://jira.sil.org/browse/LT-22303. UpdateParagraphTextForPhrase adds a "§" to each text if ParagraphParser would not recognize it as a valid segment. Ideally, we would use ParagraphParser to determine this, but it doesn't indicate whether the last segment is valid. So we mimic its behavior in EndsWithEOS.
This change is