LT-22340: Show blanks in <field> Allomorph column if that field is empty#600
Merged
jtmaxwell3 merged 7 commits intorelease/9.3from Jan 5, 2026
Merged
LT-22340: Show blanks in <field> Allomorph column if that field is empty#600jtmaxwell3 merged 7 commits intorelease/9.3from
jtmaxwell3 merged 7 commits intorelease/9.3from
Conversation
papeh
reviewed
Jan 5, 2026
| /// <param name="hvo">The hvo.</param> | ||
| /// <param name="colSpec">The col spec.</param> | ||
| /// <param name="collector">The collector.</param> | ||
| /// <param name="cache">The LcmCache.</param> |
Contributor
There was a problem hiding this comment.
nit-pick: I usually get rid of comments that don't say anything.
Contributor
There was a problem hiding this comment.
Sorry, what I meant was, I get rid of the whole line. If there are no tags, there will be no warnings about missing or extra params.
papeh
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes https://jira.sil.org/browse/LT-22340 by making (Allomorph) columns show exactly one value for each allomorph even if the value is empty or there are multiple values. I added flat="true" that produces one string for list values by calling DisplayFlat. I also added code for hvoequals="0" to handle null values.
This change is