LT-22265: Hide Invalid Columns in Bulk Edit Phoneme Features#516
Merged
papeh merged 12 commits intorelease/9.3from Dec 18, 2025
Merged
LT-22265: Hide Invalid Columns in Bulk Edit Phoneme Features#516papeh merged 12 commits intorelease/9.3from
papeh merged 12 commits intorelease/9.3from
Conversation
papeh
force-pushed
the
LT-22265
branch
6 times, most recently
from
062796e to
02df9b9
Compare
Contributor
|
Knowing our track record we should either finish this test now, or skip the commit of dead code. |
and update .gitignore (unrelated) Change-Id: Id650c14534e898426dd0fc805315bd4ce09974ee
Change-Id: I2c36f8e602bc3f6e029c0b5e940df8d5893635ac
TODO: - look at complicated cases in existing code - write unit tests - fix unit tests Change-Id: I2a612b43398e519539f37c20955fb4875fe8ce15
Change-Id: Idc60c55b8b05cd03d357aec2f7134cd887c2ae71
Change-Id: Iefd92f0aa60c03c964743a8d23d592359eb7b1cc
Fix oversimplified method to catch most things, but it still reports renamed custom fields as "bad"; check those first (need to test) Change-Id: Ib601edfa1aa670e87c7252922597769a9e259297
Doesn't work because the Layout hasn't been set up everywhere Change-Id: Ic7593a7f2a25749fb1f5aa3664f8266cc0ec8eca
Change-Id: Iebbbd8da9411b209313024f5ac5b071203fc364b
Change-Id: I628fc99c77ea267cfcef4fda877c5c584b0c88ae
papeh
commented
Dec 18, 2025
Contributor
Author
papeh
left a comment
papeh
left a comment
There was a problem hiding this comment.
@papeh made 1 comment.
Reviewable status: 0 of 6 files reviewed, all discussions resolved (waiting on @jasonleenaylor).
Src/Common/Controls/XMLViews/XMLViewsTests/XmlBrowseViewBaseVcTests.cs line 181 at r1 (raw file):
Previously, jasonleenaylor (Jason Naylor) wrote…
Knowing our track record we should either finish this test now, or skip the commit of dead code.
Done
jasonleenaylor
approved these changes
Dec 18, 2025
Contributor
jasonleenaylor
left a comment
jasonleenaylor
left a comment
There was a problem hiding this comment.
@jasonleenaylor reviewed 6 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @papeh).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is