Skip to content

Removed many of the Linux specific build steps and files#380

Merged
mark-sil merged 4 commits intorelease/9.3from
cleanup
Jul 15, 2025
Merged

Removed many of the Linux specific build steps and files#380
mark-sil merged 4 commits intorelease/9.3from
cleanup

Conversation

@mark-sil
Copy link
Contributor

@mark-sil mark-sil commented Jun 26, 2025

Change-Id: I88c3f7c9e7d8c3d9eb24a20a6b773980ab81d4d8


This change is Reviewable

Change-Id: I88c3f7c9e7d8c3d9eb24a20a6b773980ab81d4d8
Copy link
Contributor Author

@mark-sil mark-sil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 170 files reviewed, 1 unresolved discussion


a discussion (no related file):
Probably should wait to merge this until after I return from vacation; so that I’m available to fix any problems this change might cause.

Copy link
Contributor

@aror92 aror92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 155 of 170 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: 157 of 170 files reviewed, 3 unresolved discussions


Src/Common/Controls/FwControls/FwControls.csproj line 546 at r2 (raw file):

    </EmbeddedResource>
  </ItemGroup>
  <ItemGroup />

Why is this extra itemgroup needed?


Build/mkall.targets line 92 at r2 (raw file):

	</Target>

	<Target Name="FwKernel" DependsOnTargets="GenericLib;GenerateCellarConstants;AppCore;createCompMaps;CopyDlls">

Why isn't createCompMaps needed anymore here? It seems like the compmap is still handled at line 152 (or line 115 in the new line numbering)

Change-Id: Ie4b7bff4456d794b044b84e643df2b3416b25840
Copy link
Contributor Author

@mark-sil mark-sil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 155 of 171 files reviewed, 2 unresolved discussions (waiting on @aror92)


Build/mkall.targets line 92 at r2 (raw file):

Previously, aror92 (Ariel Ror.) wrote…

Why isn't createCompMaps needed anymore here? It seems like the compmap is still handled at line 152 (or line 115 in the new line numbering)

Good catch. createCompMaps was a target in Linux.targets line 216.  Since I deleted Linux.targets I removed the dependency from FwKernel, but I didn’t also look at what createCompMaps was generating and remove those references. I now removed those references.


Src/Common/Controls/FwControls/FwControls.csproj line 546 at r2 (raw file):

Previously, aror92 (Ariel Ror.) wrote…

Why is this extra itemgroup needed?

I didn't add it directly; this file was edited by Visual Studio when I removed the other files. I removed the additional ItemGroup.

Copy link
Contributor

@aror92 aror92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 13 of 170 files at r1, 3 of 3 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mark-sil)

@mark-sil mark-sil merged commit 946ed1c into release/9.3 Jul 15, 2025
5 checks passed
@mark-sil mark-sil deleted the cleanup branch July 15, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants