Removed many of the Linux specific build steps and files#380
Removed many of the Linux specific build steps and files#380mark-sil merged 4 commits intorelease/9.3from
Conversation
Change-Id: I88c3f7c9e7d8c3d9eb24a20a6b773980ab81d4d8
mark-sil
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 170 files reviewed, 1 unresolved discussion
a discussion (no related file):
Probably should wait to merge this until after I return from vacation; so that I’m available to fix any problems this change might cause.
aror92
left a comment
There was a problem hiding this comment.
Reviewed 155 of 170 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: 157 of 170 files reviewed, 3 unresolved discussions
Src/Common/Controls/FwControls/FwControls.csproj line 546 at r2 (raw file):
</EmbeddedResource> </ItemGroup> <ItemGroup />
Why is this extra itemgroup needed?
Build/mkall.targets line 92 at r2 (raw file):
</Target> <Target Name="FwKernel" DependsOnTargets="GenericLib;GenerateCellarConstants;AppCore;createCompMaps;CopyDlls">
Why isn't createCompMaps needed anymore here? It seems like the compmap is still handled at line 152 (or line 115 in the new line numbering)
Change-Id: Ie4b7bff4456d794b044b84e643df2b3416b25840
mark-sil
left a comment
There was a problem hiding this comment.
Reviewable status: 155 of 171 files reviewed, 2 unresolved discussions (waiting on @aror92)
Build/mkall.targets line 92 at r2 (raw file):
Previously, aror92 (Ariel Ror.) wrote…
Why isn't createCompMaps needed anymore here? It seems like the compmap is still handled at line 152 (or line 115 in the new line numbering)
Good catch. createCompMaps was a target in Linux.targets line 216. Since I deleted Linux.targets I removed the dependency from FwKernel, but I didn’t also look at what createCompMaps was generating and remove those references. I now removed those references.
Src/Common/Controls/FwControls/FwControls.csproj line 546 at r2 (raw file):
Previously, aror92 (Ariel Ror.) wrote…
Why is this extra itemgroup needed?
I didn't add it directly; this file was edited by Visual Studio when I removed the other files. I removed the additional ItemGroup.
aror92
left a comment
There was a problem hiding this comment.
Reviewed 13 of 170 files at r1, 3 of 3 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @mark-sil)
Change-Id: I88c3f7c9e7d8c3d9eb24a20a6b773980ab81d4d8
This change is