LT-21945: Different modes for parsing vs. analyzing#373
LT-21945: Different modes for parsing vs. analyzing#373jtmaxwell3 merged 6 commits intorelease/9.3from
Conversation
jasonleenaylor
left a comment
There was a problem hiding this comment.
Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jtmaxwell3)
Src/LexText/Interlinear/InterlinVc.cs line 380 at r1 (raw file):
} public bool GetParsingMode()
This is almost not worth doing, but let's change this to a property, maybe IsParsingMode? It makes the code read a bit better.
Src/LexText/Interlinear/SandboxBase.ComboHandlers.cs line 1128 at r1 (raw file):
ITsStrBldr builder = TsStringUtils.MakeStrBldr(); ITsString space = TsStringUtils.MakeString(fBaseWordIsPhrase ? " " : " ", m_wsVern); var guess_services = new AnalysisGuessServices(m_caches.MainCache, m_sandbox.InterlinDoc.GetMaster().GetParsingMode());
Evaluate if InterlinDoc, or GetMaster can ever be null, if they could be then add a '?' before the '.' to prevent any null references in edge case scenarios.
jasonleenaylor
left a comment
There was a problem hiding this comment.
Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jtmaxwell3)
This implements https://jira.sil.org/browse/LT-21945. It includes the following changes:
This change is