LT-22101: Problem adding a column in affix template#371
Merged
jtmaxwell3 merged 5 commits intorelease/9.3from Jun 23, 2025
Merged
LT-22101: Problem adding a column in affix template#371jtmaxwell3 merged 5 commits intorelease/9.3from
jtmaxwell3 merged 5 commits intorelease/9.3from
Conversation
jasonleenaylor
approved these changes
Jun 23, 2025
Contributor
jasonleenaylor
left a comment
jasonleenaylor
left a comment
There was a problem hiding this comment.
Reviewed 3 of 4 files at r1, all commit messages.
Reviewable status: 3 of 4 files reviewed, all discussions resolved
jasonleenaylor
pushed a commit
that referenced
this pull request
Jul 1, 2025
* Fix LT-21867: HC rule doesn't work * Fix unit test * Fix LT-22101: Problem adding a column in affix template
jasonleenaylor
pushed a commit
that referenced
this pull request
Jul 1, 2025
* Fix LT-21867: HC rule doesn't work * Fix unit test * Fix LT-22101: Problem adding a column in affix template
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, adding a new slot to a template attached to an embedded part of speech would cause the slot to be created in the top part of speech because slots couldn't be moved. This is confusing to users since they don't see the new slot. Since slots can now be moved (https://jira.sil.org/browse/LT-21757), I changed the code to create the slot in the part of speech where the template is defined.
I accidentally included some changes related to LT-21867. Its pull request should be dealt with before this one, and its changes ignored in this one.
This change is