LT-22064: Issue with uppercase words in "Word Analyses" view#279
Merged
JakeOliver28 merged 1 commit intorelease/9.3from Mar 6, 2025
Merged
LT-22064: Issue with uppercase words in "Word Analyses" view#279JakeOliver28 merged 1 commit intorelease/9.3from
JakeOliver28 merged 1 commit intorelease/9.3from
Conversation
JakeOliver28
approved these changes
Mar 6, 2025
Contributor
JakeOliver28
left a comment
JakeOliver28
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved
jasonleenaylor
pushed a commit
that referenced
this pull request
Mar 11, 2025
Fix LT-22064: Issue with uppercase words in "Word Analyses" view (cherry picked from commit c117685)
aror92
pushed a commit
that referenced
this pull request
Mar 12, 2025
Fix LT-22064: Issue with uppercase words in "Word Analyses" view (cherry picked from commit c117685)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In https://jira.sil.org/browse/LT-22047, Ron Lockwood complained that uppercase wordforms that were assigned a lowercase analysis still appeared in the Word Analyses window. I thought that I had a fix for this issue, but https://jira.sil.org/browse/LT-22064 showed that the uppercase wordform still appeared in the Word Analyses window if you closed and reopened the project before it was assigned a lowercase analysis. I fixed LT-22064 by explicitly deleting the uppercase wordform if it didn't appear in the corpus when it was assigned a lowercase analysis.
This should be included in release/9.2.
This change is