Fixes the issue of options.followRedirect not overriding globals.followRedirect if options.followRedirect is false. #534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…owRedirect if options.followRedirect is false. (options.attr || globals.attr) works well when attr is not boolean. For boolean, if the value of options.attr is set to false (or any falsey value), it will always fall back to globals.attr. In this case, the default value of globals.followRedirect being true, setting options.followRedirect to false does not set followRedirect to false as expected. This commit fixes this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(options.attr || globals.attr) works well when attr is not boolean. For boolean, if the value of options.attr is set to false (or any falsy value), it will always fall back to globals.attr. In this case, the default value of globals.followRedirect being true, setting options.followRedirect to false does not set followRedirect to false as expected. This commit fixes this issue.