Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: modify redis version to v8.11.5 #582

Merged
merged 33 commits into from
Jul 20, 2022
Merged

feat: modify redis version to v8.11.5 #582

merged 33 commits into from
Jul 20, 2022

Conversation

houseme
Copy link
Collaborator

@houseme houseme commented Jul 19, 2022

feat: modify redis version to v8.11.5
#581 #571 #572

@houseme houseme requested a review from silenceper July 20, 2022 03:24
@houseme houseme merged commit adf142d into silenceper:v2 Jul 20, 2022
@@ -66,12 +64,10 @@ func (r *Client) AccountDel(options AccountDelOptions) (info util.CommonError, e
accessToken string
data []byte
)
accessToken, err = r.ctx.GetAccessToken()
if err != nil {
if accessToken, err = r.ctx.GetAccessToken(); err != nil {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这些无关的提交,不要在一个pr中提交,只关注解析的问题。避免大批量文件的改动

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个应该是以前提交的代码 ,没有新分支

@silenceper
Copy link
Owner

silenceper commented Jul 20, 2022

@houseme pr 至少有一个Reviewers /LGTM之后再merge至master

@houseme
Copy link
Collaborator Author

houseme commented Jul 20, 2022

@houseme pr 至少有一个Reviewers /LGTM之后再merge至master

OK,这次就是修改了 go.mod 文件

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants