Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed HTTP verbs for Consul 1.0.0 breaking changes #65

Merged
merged 1 commit into from
Oct 20, 2017

Conversation

eugeneduvenage
Copy link

As mentioned in #64 Consul 1.0.0 has breaking changes with regards to enforcing HTTP verbs on the API endpoints.

This PR updates all the endpoints mentioned in their changelog to use the correct verbs, the changed endpoints are listed below.

  • /agent/join/:address
  • /agent/force-leave
  • /agent/check/register
  • /agent/check/deregister/:check_id
  • /agent/check/pass/:check_id
  • /agent/check/warn/:check_id
  • /agent/check/fail/:check_id
  • /agent/service/register
  • /agent/service/deregister/:service_id
  • /agent/service/maintenance/:service_id

Version 1.0.0 seems to add a few new routes (I have found 3 so far), I have not included those in this PR, I'll submit a second one that completes the 1.0.0 API as its a bit more work.

@silas silas merged commit 160dcde into silas:master Oct 20, 2017
@silas
Copy link
Owner

silas commented Oct 20, 2017

Thanks for the PR.

I fixed it in 8c4c1ce, but to make a PUT call you should use this.consul._put

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants