Feature/storybook #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
3f4079a
|
| Status: | 🚫 Build failed. |
| /> | ||
|
|
||
| <Story | ||
| name="Disabled" |
Contributor
There was a problem hiding this comment.
Do you have to write this all up or does storybook generate it from our components? Some of the stories like 'Disabled' might not be essential as they can be set by the prop on the other stories.
hobbitronics
approved these changes
May 19, 2021
Contributor
hobbitronics
left a comment
hobbitronics
left a comment
There was a problem hiding this comment.
Great work Ryan. I can't wait to see what other benefits we can gain from this like documentation generation.
briskt
approved these changes
May 19, 2021
Contributor
briskt
left a comment
briskt
left a comment
There was a problem hiding this comment.
It's all new to me, so I don't have much to add to the review. Looks encouraging, though!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds storybook. You can run with
npm run dev. You will see some babel warnings. I tried for a while to resolve it but can't. Will try again in the future.This leverages a github action to run
npm run build, commits, & pushes to the gh-pages branch which is hosted here: https://silinternational.github.io/ui-components/index.htmlWe can also automatically deploy to npm using this approach.