Skip to content

Drawer story and additions #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Jun 7, 2021
Merged

Drawer story and additions #36

merged 20 commits into from
Jun 7, 2021

Conversation

@hobbitronics
Copy link
Contributor

@hobbitronics hobbitronics commented Jun 7, 2021

Added

  • toggle (opens and closes Drawer when modal or dismissible), dismissible(Drawer is hidden by default) and hasTopAppBar props to Drawer
  • Drawer.stories.svelte
  • updated CHANGELOG and README
  • added a demo theme for stories and imported

Changed

  • used global rules in Drawer

hobbitronics added 20 commits May 26, 2021 14:19
@hobbitronics
added Drawer.stories.svelte
3c897bb
@hobbitronics
added a theme for stories
225acd1
@hobbitronics
Merge branch 'develop' into feature/Drawer-story
67be437
@hobbitronics
removed TopAppBar from Drawer
0ca417e
@hobbitronics
moved to Atoms, unused code, added an icon
dd1f25e
@hobbitronics
missing list and core-styles per README
6c7169d
@hobbitronics
imported _index.scss for sample theme
722c5cc
@hobbitronics
added TopAppBar in if block and props.
19313ed
@hobbitronics
added body to Drawer story
462441e
@hobbitronics
npm i after merging develop
e292a40
@hobbitronics
removed toggle
73d46f8
@hobbitronics
added toggle prop and reactive statements
423d125
@hobbitronics
added dismissible story and buttons, modlecule
667743a
@hobbitronics
used global classes
c76c0eb
@hobbitronics
set modal to false by default
0455449
@hobbitronics
no need to set modal to false when dismissible
33b5127
@hobbitronics
check dismissible before turning modal off
7805aed
@hobbitronics
updated README and CHANGELOG
7dd8c32
@hobbitronics
removed colors and add a color from theme
1cac5c2
@hobbitronics
typo in CHANGELOG
94cc4f2
@hobbitronics hobbitronics requested a review from briskt June 7, 2021 21:25
briskt
briskt approved these changes Jun 7, 2021
View reviewed changes
components/mdc/Drawer/Drawer.svelte
const isMenuItemActive = (currentUrl, menuItemUrl) => currentUrl === menuItemUrl
$: currentUrl = window.location.pathname
$: toggle, toggleDrawer()
Copy link
Contributor

@briskt briskt Jun 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does $: toggle, toggleDrawer() work the same as $: toggle && toggleDrawer() ? At one point I thought so, but I haven't been able to get it to work recently.

@hobbitronics hobbitronics merged commit 49e8862 into develop Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@briskt briskt briskt approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hobbitronics @briskt