Skip to content

use actions/deploy-pages #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2025
Merged

use actions/deploy-pages #317

merged 1 commit into from
Nov 7, 2025

Conversation

@hobbitronics
Copy link
Contributor

@hobbitronics hobbitronics commented Nov 7, 2025 •
edited
Loading

ITSE-2231 npm security changes - Phase 1 starting October 13

Changed

  • use actions/deploy-pages to eliminate needing a token

Feature branch checklist

  • Documentation (README, etc.)
  • Run make format, make dry and make install

@hobbitronics hobbitronics requested a review from a team as a code owner November 7, 2025 09:06
@hobbitronics hobbitronics requested review from briskt, ethancanne, forevermatt and mtompset and removed request for a team November 7, 2025 09:06
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 7, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@briskt
Copy link
Contributor

briskt commented Nov 7, 2025

Is there a YouTrack issue for this (and your other PR)?

@hobbitronics
Copy link
Contributor Author

hobbitronics commented Nov 7, 2025

Is there a YouTrack issue for this (and your other PR)?

Yes, sorry I forgot with the first one as I skipped a feature branch ITSE-2231 npm security changes - Phase 1 starting October 13

@hobbitronics hobbitronics merged commit 3371562 into develop Nov 7, 2025
3 checks passed
@hobbitronics hobbitronics deleted the feature/use-actions-deploy-pages branch November 7, 2025 23:27
@hobbitronics hobbitronics mentioned this pull request Nov 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@briskt briskt briskt approved these changes

@forevermatt forevermatt Awaiting requested review from forevermatt forevermatt is a code owner automatically assigned from sil-org/js-devs

@mtompset mtompset Awaiting requested review from mtompset mtompset is a code owner automatically assigned from sil-org/js-devs

@ethancanne ethancanne Awaiting requested review from ethancanne ethancanne is a code owner automatically assigned from sil-org/js-devs

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hobbitronics @briskt