Skip to content

More stories, Tour bugfix #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
May 28, 2021
Merged

More stories, Tour bugfix #29

merged 16 commits into from
May 28, 2021

Conversation

@hobbitronics
Copy link
Contributor

@hobbitronics hobbitronics commented May 27, 2021 •
edited
Loading

Changed

  • README - Instructions for running Storybook locally

Added

  • $$props.class to Badge, Form, CustomCard, Tour and StaticChip so they can accept global classes
  • Badge, CustomCard, Form, StaticChip and Tour stories to Storybook

Fixed

  • Tour was failing to replace key with value of data prop in steps content.
    Screen Shot 2021-05-27 at 4 03 08 PM
    Screen Shot 2021-05-27 at 4 09 18 PM
    Screen Shot 2021-05-27 at 4 10 24 PM

@hobbitronics hobbitronics merged commit acb535a into develop May 28, 2021
@hobbitronics hobbitronics deleted the feature/more-stories branch May 28, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@briskt briskt Awaiting requested review from briskt

@protoEvangelion protoEvangelion Awaiting requested review from protoEvangelion

1 more reviewer

@kode-monki kode-monki kode-monki approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hobbitronics @kode-monki