Only dispatch Select's populated event when appropriate
#232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a problem where, when the Select's value is changed (by the user), the `change` and `populated` events are both dispatched, even if the list of options is unchanged. Those subsequent dispatches of the `populated` event make it too easy for consumers of this component to accidentally set the value of the Select back to what it was an instant before, effectively preventing the user's choice from "sticking" sometimes.
| let element = {} | ||
| let mdcSelect = {} | ||
| let previousOptionsIDsCSV = '' |
There was a problem hiding this comment.
Will this be passed in, or how are you setting this to previous option IDs?
Contributor
There was a problem hiding this comment.
It happens on line 55 inside afterUpdate. The first time options is populated it will be empty, meaning optionsHaveChanged will return true. Is that correct @forevermatt?
hobbitronics
approved these changes
Oct 24, 2023
Contributor
hobbitronics
left a comment
hobbitronics
left a comment
There was a problem hiding this comment.
Looks good. Thanks for fixing this.
| let element = {} | ||
| let mdcSelect = {} | ||
| let previousOptionsIDsCSV = '' |
Contributor
There was a problem hiding this comment.
It happens on line 55 inside afterUpdate. The first time options is populated it will be empty, meaning optionsHaveChanged will return true. Is that correct @forevermatt?
Contributor
|
🎉 This PR is included in version 10.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
Selectcomponent dispatchpopulatedevents on initial load or changes to the list of optionschangeandpopulatedevents are both dispatched, even if the list of options is unchanged. Those subsequent dispatches of thepopulatedevent made it too easy for consumers of this component to accidentally set the value of the Select back to what it was an instant before, effectively preventing the user's choice from "sticking" sometimes.