Skip to content

add(DataTable): add lowContrast prop to DataRowItem #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2023
Merged

add(DataTable): add lowContrast prop to DataRowItem #221

merged 1 commit into from
Sep 11, 2023

Conversation

@hobbitronics
Copy link
Contributor

@hobbitronics hobbitronics commented Sep 11, 2023

  • makes the Row Item low contrast when true

@hobbitronics hobbitronics requested a review from a team September 11, 2023 02:33
@merchako
Copy link
Contributor

merchako commented Sep 11, 2023

Nice!

Learning moment: I noticed that .lowContrast is camelcase, which is unusual for CSS classes. Is that a particular convention for Svelte? Perhaps since it aligns with a component property?

@hobbitronics
Copy link
Contributor Author

hobbitronics commented Sep 11, 2023 via email

@hobbitronics hobbitronics merged commit 19d09d0 into develop Sep 11, 2023
@hobbitronics hobbitronics deleted the feat/add-lowContrast-to-DataRowItem branch September 11, 2023 21:56
@hobbitronics
Copy link
Contributor Author

hobbitronics commented Sep 15, 2023

🎉 This PR is included in version 10.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@merchako merchako merchako approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

released

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hobbitronics @merchako