Remove unused url (opensearch-project#3847)

* Remove unused url Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com> * Add changelog for the cleanup issue Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com> --------- Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com> Signed-off-by: David Sinclair <david@sinclair.tech>
sikhote · Apr 24, 2023 · 82a5f19 · 82a5f19
1 parent 109a9ca
commit 82a5f19
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -117,6 +117,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 - [Vega] Add Filter custom label for opensearchDashboardsAddFilter ([#3640](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3640))
 - [Timeline] Fix y-axis label color in dark mode ([#3698](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3698))
 - [Table Visualization] Fix data table not adjusting height on the initial load ([#3816](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3816))
+- Cleanup unused url ([#3847](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3847))
 
 ### 🚞 Infrastructure
 

diff --git a/src/plugins/discover/public/application/angular/doc_table/create_doc_table_react.tsx b/src/plugins/discover/public/application/angular/doc_table/create_doc_table_react.tsx
@@ -88,7 +88,6 @@ export function convertDirectiveToRenderFn(
     return () => {
       if (!rejected) {
         // for cleanup
-        // http://roubenmeschian.com/rubo/?p=51
         cleanupFnPromise.then((cleanup) => cleanup());
       }
     };

diff --git a/src/plugins/discover/public/application/doc_views/doc_views_helpers.tsx b/src/plugins/discover/public/application/doc_views/doc_views_helpers.tsx
@@ -98,7 +98,6 @@ export function convertDirectiveToRenderFn(
     return () => {
       if (!rejected) {
         // for cleanup
-        // http://roubenmeschian.com/rubo/?p=51
         cleanupFnPromise.then((cleanup) => cleanup());
       }
     };