Avoid unnecessary force write. (apache#3847)

* Avoid unnecessary force write. * code clean. * fix style
sijie · Jul 12, 2024 · fa80202 · fa80202
1 parent 8b65a36
commit fa80202
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java
@@ -366,6 +366,7 @@ public static class ForceWriteRequest {
         private boolean shouldClose;
         private long lastFlushedPosition;
         private long logId;
+        private boolean flushed;
 
         public int process() {
             closeFileIfNecessary();
@@ -381,13 +382,20 @@ public int process() {
             return forceWriteWaiters.size();
         }
 
+        private void flushFileToDisk() throws IOException {
+            if (!flushed) {
+                logFile.forceWrite(false);
+                flushed = true;
+            }
+        }
+
         public void closeFileIfNecessary() {
             // Close if shouldClose is set
             if (shouldClose) {
                 // We should guard against exceptions so its
                 // safe to call in catch blocks
                 try {
-                    logFile.forceWrite(false);
+                    flushFileToDisk();
                     logFile.close();
                     // Call close only once
                     shouldClose = false;
@@ -532,7 +540,7 @@ public void run() {
         private void syncJournal(ForceWriteRequest lastRequest) throws IOException {
             long fsyncStartTime = MathUtils.nowInNano();
             try {
-                lastRequest.logFile.forceWrite(false);
+                lastRequest.flushFileToDisk();
                 journalStats.getJournalSyncStats().registerSuccessfulEvent(MathUtils.elapsedNanos(fsyncStartTime),
                         TimeUnit.NANOSECONDS);
                 lastLogMark.setCurLogMark(lastRequest.logId, lastRequest.lastFlushedPosition);