Add GitHub Actions workflow for testing and implement new tests#10
Merged
Add GitHub Actions workflow for testing and implement new tests#10
Conversation
…ata transformation and utilities
added 10 commits
May 18, 2025 00:37
…d color validation
…Suite, and utilsSuite tests for cleaner output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several updates, including the addition of a new GitHub Actions workflow for testing, renaming and refactoring of utility functions, enhancements to test coverage, and the introduction of new test fixtures. Below is a categorized summary of the most important changes:
CI/CD Enhancements:
.github/workflows/test.yml) to automate testing using Bun, triggered on pushes and pull requests to themainbranch.Code Refactoring:
timestampInSecondsToStringtoSecondsToStringacross multiple files for improved readability and consistency. [1] [2] [3] [4] [5] [6] [7]Test Suite Improvements:
ChartServiceinsrc/test/services/ChartServiceSuite.test.tsto verify chart creation functionality.utilsSuitetest suite to include tests for utility functions such asgetTopNDamageDealers,sortGuildRaidResultDesc, andSecondsToString.DataTranformationServiceSuit.test.tstoDataTranformationServiceSuite.test.tsand updated its test data and descriptions for clarity.Test Fixtures:
GuildRaidResultFixtureand updatedRaidResultFixture) insrc/test/testFixtures.tsto support enhanced testing scenarios. [1] [2]Code Cleanup:
getCommandsfunction insrc/lib/utils.ts.