Skip to content

Add GitHub Actions workflow for testing and implement new tests#10

Merged
sigubrat merged 11 commits intomainfrom
test-action
May 20, 2025
Merged

Add GitHub Actions workflow for testing and implement new tests#10
sigubrat merged 11 commits intomainfrom
test-action

Conversation

@sigubrat
Copy link
Owner

This pull request introduces several updates, including the addition of a new GitHub Actions workflow for testing, renaming and refactoring of utility functions, enhancements to test coverage, and the introduction of new test fixtures. Below is a categorized summary of the most important changes:

CI/CD Enhancements:

  • Added a new GitHub Actions workflow (.github/workflows/test.yml) to automate testing using Bun, triggered on pushes and pull requests to the main branch.

Code Refactoring:

  • Renamed the utility function timestampInSecondsToString to SecondsToString across multiple files for improved readability and consistency. [1] [2] [3] [4] [5] [6] [7]

Test Suite Improvements:

  • Added a new test suite for ChartService in src/test/services/ChartServiceSuite.test.ts to verify chart creation functionality.
  • Expanded the utilsSuite test suite to include tests for utility functions such as getTopNDamageDealers, sortGuildRaidResultDesc, and SecondsToString.
  • Renamed DataTranformationServiceSuit.test.ts to DataTranformationServiceSuite.test.ts and updated its test data and descriptions for clarity.

Test Fixtures:

  • Introduced new test fixtures (GuildRaidResultFixture and updated RaidResultFixture) in src/test/testFixtures.ts to support enhanced testing scenarios. [1] [2]

Code Cleanup:

  • Removed unnecessary logging and warnings from the getCommands function in src/lib/utils.ts.

@sigubrat sigubrat self-assigned this May 17, 2025
@sigubrat sigubrat merged commit 27bb2d2 into main May 20, 2025
@sigubrat sigubrat deleted the test-action branch May 20, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant