Upload SLSA provenance to existing release #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the behavior of the provenance generator to not create a new release, since goreleaser already does. We add two steps to download the created provenance and upload it to the existing draft release. Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
hectorj2f
approved these changes
Jan 13, 2023
cpanato
approved these changes
Jan 13, 2023
There was a problem hiding this comment.
we also can disable https://github.com/sigstore/timestamp-authority/blob/main/.goreleaser.yml#L95 then this part is not needed, but i am also fine with this
thanks!
|
If we disable it in goreleaser, would the artifacts that are produced as part of it still be uploaded to the release created in the slsa provenance generator step? I wasn't sure, and someone pointed me to this approach. I'll try this, but happy to change it to either! |
|
Working as expected - Draft release is created, artifact is uploaded to the same tag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the behavior of the provenance generator to not create a new release, since goreleaser already does. We add two steps to download the created provenance and upload it to the existing draft release.
Signed-off-by: Hayden Blauzvern hblauzvern@google.com
Summary
Release Note
Documentation