Enable smoke tests for fork PRs using public OIDC beacon #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fork PRs cannot access GitHub Actions' OIDC token permissions (id-token: write), causing smoke tests to fail. This change uses the (unsafe) public beacon from sigstore-conformance to provide a valid token for fork PRs. Signed-off-by: Landon Grindheim <landon.grindheim@gmail.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
woodruffw
reviewed
Oct 17, 2025
Signed-off-by: Landon Grindheim <landon.grindheim@gmail.com>
landongrindheim
force-pushed
the
allow-smoke-tests-to-run-on-forks
branch
from
dea555f to
a251c01
Compare
landongrindheim
force-pushed
the
allow-smoke-tests-to-run-on-forks
branch
from
69c426e to
bbf68c9
Compare
Signed-off-by: Landon Grindheim <landon.grindheim@gmail.com>
landongrindheim
force-pushed
the
allow-smoke-tests-to-run-on-forks
branch
from
bbf68c9 to
29c58cc
Compare
Note: This is not tied to a release, so Dependabot (or another similar tool) will not update it automatically. Signed-off-by: Landon Grindheim <landon.grindheim@gmail.com>
woodruffw
reviewed
Oct 20, 2025
Co-authored-by: William Woodruff <william@yossarian.net> Signed-off-by: Landon Grindheim <landon.grindheim@gmail.com>
Member
|
(I kicked the CI over because it failed on a flake with the OIDC beacon that was my own doing. Sorry about that.) |
GrantBirki
pushed a commit
to GrantBirki/sigstore-ruby
that referenced
this pull request
Oct 22, 2025
Co-authored-by: William Woodruff <william@yossarian.net> Signed-off-by: GrantBirki <grant.birkinbine@gmail.com>
segiddins
pushed a commit
that referenced
this pull request
Oct 25, 2025
* bump version Signed-off-by: GrantBirki <grant.birkinbine@gmail.com> * Enable smoke tests for fork PRs using public OIDC beacon (#267) Co-authored-by: William Woodruff <william@yossarian.net> Signed-off-by: GrantBirki <grant.birkinbine@gmail.com> * Clarify/tweak wording (#235) Co-authored-by: William Woodruff <william@yossarian.net> Signed-off-by: GrantBirki <grant.birkinbine@gmail.com> --------- Signed-off-by: GrantBirki <grant.birkinbine@gmail.com> Co-authored-by: Landon Grindheim <landon.grindheim@gmail.com> Co-authored-by: William Woodruff <william@yossarian.net> Co-authored-by: Jeff Widman <jeff@jeffwidman.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fork PRs cannot access GitHub Actions' OIDC token permissions (id-token: write), causing smoke tests to fail. This change uses the (unsafe) public beacon from sigstore-conformance to provide a valid token for fork PRs. My hope in taking this approach is to allow forks to have smoke tests run against them, but continue to rely on the GitHub Actions OIDC token permissions for release and non-fork workflows.
Fixes: #262
Release Note
NONE (dev-only)
Documentation
No