sign and verify with Rekorv2 #1414
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
15 tasks
|
I'm combing through this PR now: I think instead of working on top of this I will take specific commits (at least rekov2-client...jku:sigstore-python:sign-with-rekorv2 is the working branch |
jku
reviewed
Jun 9, 2025
Comment on lines
+585
to
+588
| public_key=v2.PublicKey( | ||
| raw_bytes=bundle.signing_certificate.public_key().public_bytes( | ||
| encoding=serialization.Encoding.DER, | ||
| format=serialization.PublicFormat.SubjectPublicKeyInfo, |
There was a problem hiding this comment.
this looks strange to me: if the bundle contains a signing certificate, we should expect the signature to contain that (and not just the public key of the certificate), right?
There was a problem hiding this comment.
I've used the certificate in my PR, I think it looks ok
This was referenced Jun 9, 2025
|
I think I have an updated version in #1432 -- @ramonpetgrave64 there might still be something we want here, but I'm going to close this one for clarity for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client support for Rekor V2: sigstore-python #289
Summary
This PR, in favor of #1387
Pending #1400
Enables signing and verifying with Rekorv2 via a trust-config.
Testing
Unit tests should pass, but are currently using somewhat hacky method of paramaterizing fixtures to use either staging or the embedded tust_config.
TODO:
Release Note
Documentation