Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start of an action to install kind,knative and sigstore pieces + tests. #85

Merged
merged 8 commits into from
Mar 31, 2022

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented Mar 30, 2022

Signed-off-by: Ville Aikas vaikas@chainguard.dev

Summary

Start of a github action that can be reused from other repos more easily.

Ticket Link

Fixes

Release Note

Start of a github action reusable action.

Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
@vaikas
Copy link
Contributor Author

vaikas commented Mar 30, 2022

@cpanato I wasn't sure how to test this before actually merging it since it doesn't seem to be usable before it's in there. Any ideas? Looks like after it goes in, you can refer to the commit? Maybe I could try pointing it to my branch at that commit?

Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
@vaikas
Copy link
Contributor Author

vaikas commented Mar 30, 2022

@cpanato that seemed to work :) Well, I can run against it :)

Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>

steps:
- name: Test running the action
uses: vaikas/scaffolding/actions/setup@91b2092691e21133879a133e9c2243e1e1311fe9
Copy link
Member

@cpanato cpanato Mar 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to test it you can do the following

    steps:
    - uses: actions/checkout@a12a3943b4bdde767164f792f33f40b04645d846 # v3
    - name: Test running the action
      uses: ./actions/setup

Copy link
Member

@cpanato cpanato Mar 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
@vaikas
Copy link
Contributor Author

vaikas commented Mar 31, 2022

@cpanato awesomesauce, thanks! Trying with that now :)

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool!!

@cpanato cpanato merged commit 5f4dcd3 into sigstore:main Mar 31, 2022
@vaikas vaikas deleted the actionjackson branch March 31, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants