Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: actions/cache #141

Merged
merged 1 commit into from
Apr 29, 2022
Merged

fix: actions/cache #141

merged 1 commit into from
Apr 29, 2022

Conversation

embano1
Copy link
Contributor

@embano1 embano1 commented Apr 26, 2022

Summary

Fixes actions/cache in the E2E tests by properly constructing a cache key and reordering certain steps to populate/reuse the cache, e.g. when installing dependencies.

Ticket Link

Fixes: #140
Signed-off-by: Michael Gasch mgasch@vmware.com

Release Note

NONE

@embano1 embano1 marked this pull request as ready for review April 29, 2022 12:37
@embano1
Copy link
Contributor Author

embano1 commented Apr 29, 2022

@vaikas you look like the main contributor to this repo, so kindly asking for your review feedback :)

Closes: sigstore#140
Signed-off-by: Michael Gasch <mgasch@vmware.com>
@cpanato
Copy link
Member

cpanato commented Apr 29, 2022

close/open to trigger a missing job

@embano1
Copy link
Contributor Author

embano1 commented Apr 29, 2022

close/open to trigger a missing job

Yeah, old trick. Though it doesn't seem to work here anymore?

@cpanato
Copy link
Member

cpanato commented Apr 29, 2022

close/open to trigger a missing job

Yeah, old trick. Though it doesn't seem to work here anymore?

sometimes, but i think this is another problem

@cpanato
Copy link
Member

cpanato commented Apr 29, 2022

thanks!

@cpanato cpanato merged commit 3e2d3a9 into sigstore:main Apr 29, 2022
@embano1 embano1 deleted the issue-140 branch April 29, 2022 13:21
@vaikas
Copy link
Contributor

vaikas commented Apr 29, 2022

Awesomesauce! Thanks @embano1

@embano1
Copy link
Contributor Author

embano1 commented Apr 29, 2022

Awesomesauce! Thanks @embano1

Always 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

actions/cache is not effective
3 participants