Allow creating alerts with multiple notification channels

Signed-off-by: Priya Wadhwa <priya@chainguard.dev>

terraform/gcp/modules/monitoring/dex/variables.tf

@@ -43,11 +43,11 @@ variable "dex_url" {
 }
 
 // Set-up for notification channel for alerting
-variable "notification_channel_id" {
-  type        = string
-  description = "The notification channel ID which alerts should be sent to. You can find this by running `gcloud alpha monitoring channels list`."
+variable "notification_channel_ids" {
+  type        = list(string)
+  description = "List of notification channel IDs which alerts should be sent to. You can find this by running `gcloud alpha monitoring channels list`."
 }
 
 locals {
-  notification_channels = [format("projects/%v/notificationChannels/%v", var.project_id, var.notification_channel_id)]
+  notification_channels = toset([for nc in var.notification_channel_ids : format("projects/%v/notificationChannels/%v", var.project_id, nc)])
 }

terraform/gcp/modules/monitoring/fulcio/variables.tf

@@ -48,13 +48,13 @@ variable "ctlog_url" {
 }
 
 // Set-up for notification channel for alerting
-variable "notification_channel_id" {
-  type        = string
-  description = "The notification channel ID which alerts should be sent to. You can find this by running `gcloud alpha monitoring channels list`."
+variable "notification_channel_ids" {
+  type        = list(string)
+  description = "List of notification channel IDs which alerts should be sent to. You can find this by running `gcloud alpha monitoring channels list`."
 }
 
 locals {
-  notification_channels = [format("projects/%v/notificationChannels/%v", var.project_id, var.notification_channel_id)]
+  notification_channels = toset([for nc in var.notification_channel_ids : format("projects/%v/notificationChannels/%v", var.project_id, nc)])
   hosts                 = [var.fulcio_url, var.ctlog_url]
 }
 

terraform/gcp/modules/monitoring/infra/variables.tf

@@ -35,11 +35,11 @@ variable "fulcio_url" {
 }
 
 // Set-up for notification channel for alerting
-variable "notification_channel_id" {
-  type        = string
-  description = "The notification channel ID which alerts should be sent to. You can find this by running `gcloud alpha monitoring channels list`."
+variable "notification_channel_ids" {
+  type        = list(string)
+  description = "List of notification channel IDs which alerts should be sent to. You can find this by running `gcloud alpha monitoring channels list`."
 }
 
 locals {
-  notification_channels = [format("projects/%v/notificationChannels/%v", var.project_id, var.notification_channel_id)]
+  notification_channels = toset([for nc in var.notification_channel_ids : format("projects/%v/notificationChannels/%v", var.project_id, nc)])
 }

terraform/gcp/modules/monitoring/prober/variables.tf

@@ -35,12 +35,12 @@ variable "fulcio_url" {
 }
 
 // Set-up for notification channel for alerting
-variable "notification_channel_id" {
-  type        = string
-  description = "The notification channel ID which alerts should be sent to. You can find this by running `gcloud alpha monitoring channels list`."
+variable "notification_channel_ids" {
+  type        = list(string)
+  description = "List of notification channel IDs which alerts should be sent to. You can find this by running `gcloud alpha monitoring channels list`."
 }
 
 locals {
-  notification_channels = [format("projects/%v/notificationChannels/%v", var.project_id, var.notification_channel_id)]
+  notification_channels = toset([for nc in var.notification_channel_ids : format("projects/%v/notificationChannels/%v", var.project_id, nc)])
   hosts                 = [var.rekor_url, var.fulcio_url]
 }

terraform/gcp/modules/monitoring/rekor/variables.tf

@@ -30,9 +30,9 @@ variable "rekor_url" {
 }
 
 // Set-up for notification channel for alerting
-variable "notification_channel_id" {
-  type        = string
-  description = "The notification channel ID which alerts should be sent to. You can find this by running `gcloud alpha monitoring channels list`."
+variable "notification_channel_ids" {
+  type        = list(string)
+  description = "List of notification channel IDs which alerts should be sent to. You can find this by running `gcloud alpha monitoring channels list`."
 }
 
 variable "api_endpoints_get" {
@@ -46,6 +46,6 @@ variable "api_endpoints_get" {
 }
 
 locals {
-  notification_channels = [format("projects/%v/notificationChannels/%v", var.project_id, var.notification_channel_id)]
+  notification_channels = toset([for nc in var.notification_channel_ids : format("projects/%v/notificationChannels/%v", var.project_id, nc)])
 }
 

terraform/gcp/modules/monitoring/sigstore.tf

@@ -34,9 +34,9 @@ resource "google_project_service" "service" {
 module "rekor" {
   source = "./rekor"
 
-  project_id              = var.project_id
-  notification_channel_id = var.notification_channel_id
-  rekor_url               = var.rekor_url
+  project_id               = var.project_id
+  notification_channel_ids = var.notification_channel_ids
+  rekor_url                = var.rekor_url
 
   depends_on = [
     google_project_service.service
@@ -47,10 +47,10 @@ module "rekor" {
 module "fulcio" {
   source = "./fulcio"
 
-  project_id              = var.project_id
-  notification_channel_id = var.notification_channel_id
-  ctlog_url               = var.ctlog_url
-  fulcio_url              = var.fulcio_url
+  project_id               = var.project_id
+  notification_channel_ids = var.notification_channel_ids
+  ctlog_url                = var.ctlog_url
+  fulcio_url               = var.fulcio_url
 
   depends_on = [
     google_project_service.service
@@ -61,8 +61,8 @@ module "fulcio" {
 module "dex" {
   source = "./dex"
 
-  project_id              = var.project_id
-  notification_channel_id = var.notification_channel_id
+  project_id               = var.project_id
+  notification_channel_ids = var.notification_channel_ids
 
   dex_url = var.dex_url
 
@@ -75,10 +75,10 @@ module "dex" {
 module "prober" {
   source = "./prober"
 
-  project_id              = var.project_id
-  notification_channel_id = var.notification_channel_id
-  rekor_url               = var.prober_rekor_url
-  fulcio_url              = var.prober_fulcio_url
+  project_id               = var.project_id
+  notification_channel_ids = var.notification_channel_ids
+  rekor_url                = var.prober_rekor_url
+  fulcio_url               = var.prober_fulcio_url
 
   depends_on = [
     google_project_service.service
@@ -88,10 +88,10 @@ module "prober" {
 module "infra" {
   source = "./infra"
 
-  project_id              = var.project_id
-  notification_channel_id = var.notification_channel_id
-  rekor_url               = local.qualified_rekor_url
-  fulcio_url              = local.qualified_fulcio_url
+  project_id               = var.project_id
+  notification_channel_ids = var.notification_channel_ids
+  rekor_url                = local.qualified_rekor_url
+  fulcio_url               = local.qualified_fulcio_url
 
   depends_on = [
     google_project_service.service

terraform/gcp/modules/monitoring/variables.tf

@@ -69,13 +69,13 @@ variable "prober_fulcio_url" {
 }
 
 // Set-up for notification channel for alerting
-variable "notification_channel_id" {
-  type        = string
-  description = "The notification channel ID which alerts should be sent to. You can find this by running `gcloud alpha monitoring channels list`."
+variable "notification_channel_ids" {
+  type        = list(string)
+  description = "List of notification channel IDs which alerts should be sent to. You can find this by running `gcloud alpha monitoring channels list`."
 }
 
 locals {
-  notification_channels = [format("projects/%v/notificationChannels/%v", var.project_id, var.notification_channel_id)]
+  notification_channels = toset([for nc in var.notification_channel_ids : format("projects/%v/notificationChannels/%v", var.project_id, nc)])
   qualified_rekor_url   = format("https://%s", var.rekor_url)
   qualified_fulcio_url  = format("https://%s", var.fulcio_url)
 }