Skip to content

Commit

Permalink
terraform: Remove useless timestamp slos
Browse files Browse the repository at this point in the history
* Clients only use /api/v1/timestamp
* Keep /api/v1/timestamp/certchain for prober availability
  (since that is the only endpoint used by prober)

Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
  • Loading branch information
jku committed Mar 10, 2025
1 parent a77f5af commit 135fd1e
Showing 1 changed file with 0 additions and 20 deletions.
20 changes: 0 additions & 20 deletions terraform/gcp/modules/monitoring/timestamp/slo.tf
Original file line number Diff line number Diff line change
Expand Up @@ -32,38 +32,18 @@ module "slos" {
# Only count 500s as server errors since clients can trigger 400s.
bad_filter = "metric.labels.code=monitoring.regex.full_match(\"5[0-9][0-9]\")"
slos = {
api-v1-all-methods = {
display_suffix = "All Methods"
label_filter = ""
goal = 0.995
},
api-v1-timestamp-post = {
display_suffix = "/api/v1/timestamp - POST"
label_filter = "metric.labels.path=\"/api/v1/timestamp\" metric.labels.method=\"POST\""
goal = 0.995
},
api-v1-timestamp-certchain-get = {
display_suffix = "/api/v1/timestamp/certchain - GET"
label_filter = "metric.labels.path=\"/api/v1/timestamp/certchain\" metric.labels.method=\"GET\""
goal = 0.995
},
}
},
prober-availability = {
display_prefix = "Availability (Prober)"
base_total_service_filter = format("metric.type=\"prometheus.googleapis.com/api_endpoint_latency_count/summary\" resource.type=\"prometheus_target\" metric.labels.host=\"%s\"", var.prober_url)
bad_filter = "metric.labels.status_code!=monitoring.regex.full_match(\"20[0-1]\")"
slos = {
api-v1-all-methods = {
display_suffix = "All Methods"
label_filter = ""
goal = 0.995
},
api-v1-timestamp-post = {
display_suffix = "/api/v1/timestamp - POST"
label_filter = "metric.labels.path=\"/api/v1/timestamp\" metric.labels.method=\"POST\""
goal = 0.995
},
api-v1-timestamp-certchain-get = {
display_suffix = "/api/v1/timestamp/certchain - GET"
label_filter = "metric.labels.path=\"/api/v1/timestamp/certchain\" metric.labels.method=\"GET\""
Expand Down

0 comments on commit 135fd1e

Please sign in to comment.