Change Redis value for locking mechanism #1957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lock value is never read. Only the key is used to determine if an instance has already created a checkpoint for a given period. Changing this to the smallest primitive value to reduce storage capacity needs. Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1957 +/- ##
==========================================
- Coverage 47.62% 47.61% -0.02%
==========================================
Files 92 92
Lines 9197 9199 +2
==========================================
Hits 4380 4380
- Misses 3941 3943 +2
Partials 876 876
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cmurphy
reviewed
Jan 17, 2024
cmurphy
approved these changes
Jan 17, 2024
bobcallaway
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lock value is never read. Only the key is used to determine if an instance has already created a checkpoint for a given period. Changing this to the smallest primitive value to reduce storage capacity needs.
Summary
Release Note
Documentation