Update java release to do sigstore sign on github #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loosebazooka
commented
May 10, 2024
| } | ||
| } | ||
| } | ||
| description = "Sigstore protobuf spec protos bundled into a jar" |
There was a problem hiding this comment.
we no longer generate code, that's delegated to the consumer (easier to handle version conflicts)
haydentherapper
approved these changes
May 10, 2024
This still needs a user to run the release script to sign with pgp locally and push the bundle to maven central. Signed-off-by: Appu Goundan <appu@google.com>
loosebazooka
force-pushed
the
update-java-release
branch
from
d9dac2b
to
1d8cd3b
Compare
|
I don't think I have the rights to merge. But this works on loosebazooka/protobuf-specs, so hopefully that just kinda translates over directly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This still needs a user to run the release script to sign with pgp locally and push the bundle to maven central.
SLSA generation has been removed temporarily. I'll figure out how to integrate with the github attestation generator in the future.