Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add algorithm registry markdown and KnownSignatureAlgorithm enumeration #194

Merged
merged 18 commits into from
Jan 17, 2024
Merged

Add algorithm registry markdown and KnownSignatureAlgorithm enumeration #194

merged 18 commits into from
Jan 17, 2024

Conversation

tetsuo-cpp
Copy link
Contributor

As part of our work to support configurable crypto algorithms in Sigstore, we're adding both a markdown file documenting the supported algorithm combinations as well as a SupportedAlgorithm enumeration to support any code that operates on these algorithms.

@tetsuo-cpp
Add SupportedAlgorithm enumeration
7a93838 
Signed-off-by: Alex Cameron <asc@tetsuo.sh>
@tetsuo-cpp
Add registry markdown doc
500ce56 
Signed-off-by: Alex Cameron <asc@tetsuo.sh>
tetsuo-cpp
tetsuo-cpp commented Jan 16, 2024
View reviewed changes
docs/algorithm-registry.md Show resolved Hide resolved
docs/algorithm-registry.md Outdated Show resolved Hide resolved
@tetsuo-cpp
Regenerate code
e52e07e 
Signed-off-by: Alex Cameron <asc@tetsuo.sh>
haydentherapper
haydentherapper reviewed Jan 17, 2024
View reviewed changes
docs/algorithm-registry.md Outdated Show resolved Hide resolved
docs/algorithm-registry.md Outdated Show resolved Hide resolved
docs/algorithm-registry.md Outdated Show resolved Hide resolved
docs/algorithm-registry.md Show resolved Hide resolved
protos/sigstore_common.proto Outdated Show resolved Hide resolved
@tetsuo-cpp
Switch to P521 with SHA-512
196acba 
Signed-off-by: Alex Cameron <asc@tetsuo.sh>
@tetsuo-cpp
Make it clear that Sigstore services aren't required to adhere to thi…
9b1d4ad 
…s registry

Signed-off-by: Alex Cameron <asc@tetsuo.sh>
@tetsuo-cpp
Rename to KnownSignatureAlgorithm
58725fe 
Signed-off-by: Alex Cameron <asc@tetsuo.sh>
@tetsuo-cpp
Correct KnownSignatureAlgorithm comment
466fc05 
Signed-off-by: Alex Cameron <asc@tetsuo.sh>
@tetsuo-cpp
Note that ed25519-ph is used for hashedrekord
1243b19 
Signed-off-by: Alex Cameron <asc@tetsuo.sh>
@tetsuo-cpp
Fix algorithm registry to list SHA-512 with P-521
c06b5d1 
Signed-off-by: Alex Cameron <asc@tetsuo.sh>
@tetsuo-cpp
Regenerate code
3d33e9a 
Signed-off-by: Alex Cameron <asc@tetsuo.sh>
@tetsuo-cpp
Add hash algorithms to registry also
3610161 
Signed-off-by: Alex Cameron <asc@tetsuo.sh>
@tetsuo-cpp
Add RSA signature algorithms to registry
d126419 
Signed-off-by: Alex Cameron <asc@tetsuo.sh>
@tetsuo-cpp tetsuo-cpp changed the title Add algorithm registry markdown and SupportedAlgorithm enumeration Add algorithm registry markdown and KnownSignatureAlgorithm enumeration Jan 17, 2024
@woodruffw
gen, protos: more HashAlgorithm variants
db90d7f 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
protos: indentation
40ea700 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
algorithm-registry: clarify the purpose of the Hash Algorithms table
fe4aafb 
Signed-off-by: William Woodruff <william@trailofbits.com>
woodruffw
woodruffw previously approved these changes Jan 17, 2024
View reviewed changes
haydentherapper
haydentherapper reviewed Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just nits on the hash chocies

docs/algorithm-registry.md Show resolved Hide resolved
docs/algorithm-registry.md Outdated Show resolved Hide resolved
docs/algorithm-registry.md Show resolved Hide resolved
docs/algorithm-registry.md Show resolved Hide resolved
@woodruffw
algorithm-registry: add sha2-512
10fb943 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
algorithm-registry: omit sha2-256/192
b46b70c 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
switcheroo
a6b56fb 
Signed-off-by: William Woodruff <william@trailofbits.com>
haydentherapper
haydentherapper approved these changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@woodruffw woodruffw merged commit 017af89 into sigstore:main Jan 17, 2024
25 checks passed
@woodruffw woodruffw deleted the alex/configurable-crypto branch January 17, 2024 23:03
@tetsuo-cpp tetsuo-cpp mentioned this pull request Jan 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodruffw woodruffw woodruffw left review comments

@haydentherapper haydentherapper haydentherapper approved these changes

@ret2libc ret2libc Awaiting requested review from ret2libc

Assignees

@tetsuo-cpp tetsuo-cpp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tetsuo-cpp @ret2libc @woodruffw @haydentherapper