Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set empty string as defaults for codefresh's optional fields #1777

Merged

Conversation

javanlacerda
Copy link
Contributor

Summary

Closes #1770

It set empty string as default value for optional fields on codefresh workflow.

Release Note

Documentation

Signed-off-by: Javan lacerda <javanlacerda@google.com>
Signed-off-by: Javan lacerda <javanlacerda@google.com>
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.35%. Comparing base (cf238ac) to head (3ef98f6).
Report is 181 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1777      +/-   ##
==========================================
- Coverage   57.93%   50.35%   -7.58%     
==========================================
  Files          50       70      +20     
  Lines        3119     4184    +1065     
==========================================
+ Hits         1807     2107     +300     
- Misses       1154     1844     +690     
- Partials      158      233      +75     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

config/identity/config.yaml Outdated Show resolved Hide resolved
Always present in token

Signed-off-by: Hayden B <hblauzvern@google.com>
@haydentherapper haydentherapper merged commit 9efbcef into sigstore:main Aug 20, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Signing from Codefresh fails when scm_repo_url claim is not provided
4 participants