Skip to content

Add proposer re-org tests for non-default thresholds#9310

Open
rahulbarmann wants to merge 1 commit into
sigp:unstablefrom
rahulbarmann:more-reorg-threshold-tests
Open

Add proposer re-org tests for non-default thresholds#9310
rahulbarmann wants to merge 1 commit into
sigp:unstablefrom
rahulbarmann:more-reorg-threshold-tests

Conversation

@rahulbarmann
Copy link
Copy Markdown

Issue Addressed

Proposed Changes

Add five proposer_boost_re_org_* tests that exercise non-default values of re_org_threshold, re_org_parent_threshold, and max_epochs_since_finalization. Each parameter gets a "permits" and a "blocks" case (where applicable) so that a test fails or changes behaviour if the parameter is silently ignored, which was the gap the issue identified.

Also adds a proposer_re_org_parent_threshold setter on BeaconChainBuilder to make the parent threshold drivable from ReOrgTest, mirroring the existing proposer_re_org_head_threshold setter.

Additional Info

Built against unstable ahead of #9177 landing, so the thresholds are still set via ChainConfig. If #9177 merges first, the builder calls in these tests can be swapped for the mut spec form per @michaelsproul's review comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant