Add proposer re-org tests for non-default thresholds#9310
Open
rahulbarmann wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Proposed Changes
Add five
proposer_boost_re_org_*tests that exercise non-default values ofre_org_threshold,re_org_parent_threshold, andmax_epochs_since_finalization. Each parameter gets a "permits" and a "blocks" case (where applicable) so that a test fails or changes behaviour if the parameter is silently ignored, which was the gap the issue identified.Also adds a
proposer_re_org_parent_thresholdsetter onBeaconChainBuilderto make the parent threshold drivable fromReOrgTest, mirroring the existingproposer_re_org_head_thresholdsetter.Additional Info
Built against
unstableahead of #9177 landing, so the thresholds are still set viaChainConfig. If #9177 merges first, the builder calls in these tests can be swapped for themut specform per @michaelsproul's review comment.