Add fork choice write lock tracing context#9306
Open
peter941221 wants to merge 1 commit into
Open
Conversation
13fb58f to
5182232
Compare
5182232 to
2612423
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Part of #8147.
Proposed Changes
Adds source-specific tracing spans around production fork-choice write-lock/update paths so lock wait spans have useful parent context in traces.
This is intentionally behavior-neutral:
Covered paths include block import, payload envelope import, attestation/slashing application, recompute-head, finalization prune, and execution payload validity updates.
The instrumentation uses a frequency-aware span level split:
info_span!so parent/source context is visible alongside the existing default#[instrument]fork-choice write-lock span in info-level tracing configurationsdebug_span!to avoid adding info-level trace noise on gossip-heavy pathsAdditional Info
This follows the instrumentation-first direction discussed in #8147.
Verifications Performed
cargo fmt --checkcargo check -p beacon_chaingit diff --check