Skip to content

Gloas gossip boilerplate#8700

Merged
mergify[bot] merged 5 commits intosigp:unstablefrom
eserilev:gloas-gossip
Jan 28, 2026
Merged

Gloas gossip boilerplate#8700
mergify[bot] merged 5 commits intosigp:unstablefrom
eserilev:gloas-gossip

Conversation

@eserilev
Copy link
Member

@eserilev eserilev commented Jan 27, 2026 •
edited
Loading

Issue Addressed

All the required boilerplate for gloas gossip. We'll include the gossip message processing logic in a separate PR

@eserilev eserilev requested a review from jxs as a code owner January 27, 2026 04:57
@eserilev eserilev added ready-for-review The code is ready for review gloas labels Jan 27, 2026
jimmygchen
jimmygchen reviewed Jan 27, 2026
View reviewed changes
jimmygchen
jimmygchen approved these changes Jan 27, 2026
View reviewed changes
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eserilev @jimmygchen
Update beacon_node/beacon_processor/src/lib.rs
e894545 
Co-authored-by: Jimmy Chen <jchen.tc@gmail.com>
@eserilev eserilev mentioned this pull request Jan 27, 2026
Open
24 tasks
jimmygchen
jimmygchen reviewed Jan 28, 2026
View reviewed changes
beacon_node/network/src/network_beacon_processor/mod.rs Outdated
};

self.try_send(BeaconWorkEvent {
drop_during_sync: false,
Copy link
Member

@jimmygchen jimmygchen Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we may want to drop this during sync?

Copy link
Member

@jimmygchen jimmygchen Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've flip this bool in 9a48927

I believe this is correct, but let me know otherwise!

Copy link
Member

@jimmygchen jimmygchen Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes in this PR are additions and unreachable in Fulu, so I think we're good to merge!

Copy link
Member

@jimmygchen jimmygchen Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chat with Eitan and also dropping GossipExecutionPayloadBid event during sync

@jimmygchen jimmygchen added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Jan 28, 2026
@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Jan 28, 2026
@mergify mergify bot added the queued label Jan 28, 2026
@mergify
Copy link

mergify bot commented Jan 28, 2026 •
edited
Loading

Merge Queue Status

🚫 The pull request has left the queue (rule: default) at 9a48927

This pull request spent 1 minute 7 seconds in the queue, with no time running CI.

Reason

The pull request #8700 has been manually updated

Hint

If you want to requeue this pull request, you can post a @mergifyio requeue comment.

@jimmygchen
Copy link
Member

jimmygchen commented Jan 28, 2026

@mergify requeue

@mergify
Copy link

mergify bot commented Jan 28, 2026

requeue

☑️ This pull request is already queued

@mergify
Copy link

mergify bot commented Jan 28, 2026 •
edited
Loading

Merge Queue Status

✅ The pull request has been merged at a4a22fe

This pull request spent 43 minutes 24 seconds in the queue, including 41 minutes 24 seconds running CI.
The checks were run on draft #8714.

Required conditions to merge
  • check-success=local-testnet-success
  • check-success=test-suite-success

mergify bot added a commit that referenced this pull request Jan 28, 2026
@mergify
Merge of #8700
a50f44a
@mergify mergify bot mentioned this pull request Jan 28, 2026
Closed
6 tasks
@mergify mergify bot merged commit b202e98 into sigp:unstable Jan 28, 2026
36 checks passed
@mergify mergify bot removed the queued label Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jimmygchen jimmygchen jimmygchen approved these changes

@jxs jxs Awaiting requested review from jxs jxs is a code owner

Assignees

No one assigned

Labels

gloas ready-for-merge This PR is ready to merge.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eserilev @jimmygchen