Skip to content

Comments

Replace INTERVALS_PER_SLOT with explicit slot component times#7944

Merged
mergify[bot] merged 61 commits intosigp:unstablefrom
eserilev:slot_duration_ms
Feb 2, 2026
Merged

Replace INTERVALS_PER_SLOT with explicit slot component times#7944
mergify[bot] merged 61 commits intosigp:unstablefrom
eserilev:slot_duration_ms

Conversation

@eserilev
Copy link
Member

Issue Addressed

ethereum/consensus-specs#4476

Additional Info

This change affects many critical paths in lighthouse and should not be merged until after 8.0.0

the Ethereum kurtosis package is working to support this change here: ethpandaops/ethereum-package#1168

@eserilev eserilev requested a review from jxs as a code owner August 26, 2025 21:44
@eserilev eserilev added spec_change A change related to the Eth2 spec blocked work-in-progress PR is a work-in-progress gloas labels Aug 26, 2025
@dapplion
Copy link
Collaborator

dapplion commented Oct 4, 2025

Should this change consider that the slot time will change in the future? Or that's to be handled in a future PR

@eserilev
Copy link
Member Author

eserilev commented Oct 6, 2025

Should this change consider that the slot time will change in the future? Or that's to be handled in a future PR

I think we should handle that in a future PR to keep this diff here as small as possible

@jimmygchen jimmygchen added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Jan 30, 2026
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @eserilev

I've reviewed the PR, please see my comments - there are a few issues but most of the changes look safe and I think we're close to merging this!

Let me know if you'd like to discuss on any of the comments or if they're unclear.

Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Peer reviewed with @jimmygchen

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Feb 2, 2026
@mergify mergify bot added the queued label Feb 2, 2026
@mergify
Copy link

mergify bot commented Feb 2, 2026

Merge Queue Status

🚫 The pull request has left the queue (rule: default) at 3178e85

This pull request spent 1 minute 17 seconds in the queue, with no time running CI.

Reason

The pull request #7944 has been manually updated

Hint

If you want to requeue this pull request, you can post a @mergifyio requeue comment.

@mergify
Copy link

mergify bot commented Feb 2, 2026

Merge Queue Status

✅ The pull request has been merged at e362f41

This pull request spent 33 minutes 11 seconds in the queue, including 31 minutes 26 seconds running CI.
The checks were run on draft #8728.

Required conditions to merge
  • check-success=local-testnet-success
  • check-success=test-suite-success

mergify bot added a commit that referenced this pull request Feb 2, 2026
@eserilev
Copy link
Member Author

eserilev commented Feb 2, 2026

thanks guys!

@mergify mergify bot merged commit 3ecf964 into sigp:unstable Feb 2, 2026
37 checks passed
@mergify mergify bot removed the queued label Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gloas ready-for-merge This PR is ready to merge. spec_change A change related to the Eth2 spec v8.1.0 Post-Fulu release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants