Replace INTERVALS_PER_SLOT with explicit slot component times#7944
Replace INTERVALS_PER_SLOT with explicit slot component times#7944mergify[bot] merged 61 commits intosigp:unstablefrom
INTERVALS_PER_SLOT with explicit slot component times#7944Conversation
|
Should this change consider that the slot time will change in the future? Or that's to be handled in a future PR |
I think we should handle that in a future PR to keep this diff here as small as possible |
beacon_node/beacon_chain/src/light_client_finality_update_verification.rs
Outdated
Show resolved
Hide resolved
beacon_node/beacon_chain/src/light_client_optimistic_update_verification.rs
Outdated
Show resolved
Hide resolved
jimmygchen
left a comment
There was a problem hiding this comment.
Hey @eserilev
I've reviewed the PR, please see my comments - there are a few issues but most of the changes look safe and I think we're close to merging this!
Let me know if you'd like to discuss on any of the comments or if they're unclear.
…ot_duration_ms
michaelsproul
left a comment
There was a problem hiding this comment.
LGTM. Peer reviewed with @jimmygchen
Merge Queue Status🚫 The pull request has left the queue (rule: This pull request spent 1 minute 17 seconds in the queue, with no time running CI. ReasonThe pull request #7944 has been manually updated HintIf you want to requeue this pull request, you can post a |
Merge Queue Status✅ The pull request has been merged at e362f41 This pull request spent 33 minutes 11 seconds in the queue, including 31 minutes 26 seconds running CI. Required conditions to merge
|
|
thanks guys! |
Issue Addressed
ethereum/consensus-specs#4476
Additional Info
This change affects many critical paths in lighthouse and should not be merged until after
8.0.0the Ethereum kurtosis package is working to support this change here: ethpandaops/ethereum-package#1168